Code Review for 6750588

Prepared by: Chuck Rasbold (rasbold) on Tue Sep 23 09:15:36 PDT 2008
Workspace:/export/rasbold/hg/6750588
Compare against: http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot
Summary of changes: 8 lines changed: 2 ins; 0 del; 6 mod; 807 unchg
Patch of changes: 6750588.patch
Author comments:
6750588: assert(lrg._area >= 0,"negative spill area") running NSK stmp0101 test
Summary: handle NaN costs more carefully
Reviewed-by:

In extreme cases not found in normal programs, an estimated block
frequency can become the float value Infinity. Calculations for cost
and area estimates in ifg_physical() can then become Inf or NaN.
Register allocation still behaves OK with these values, but asserts
will trigger without need.

The fix changes the cost calculation to not become NaN in the face of
an Inf frequency. Two asserts are tweaked to properly check for
negative values.
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/ifg.cpp

8 lines changed: 2 ins; 0 del; 6 mod; 807 unchg

This code review page was prepared using /home/rasbold/bin/webrev (vers 23.15-hg).