| Prepared by: | Thomas Rodriguez (never) on Fri Jan 9 14:17:36 PST 2009 |
|---|---|
| Workspace: | /export/ws/c2 |
| Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
| Summary of changes: | 29 lines changed: 29 ins; 0 del; 0 mod; 7322 unchg |
| Patch of changes: | 6788347.patch |
| Author comments: |
6788347: C2Compiler crash 6u7 Reviewed-by: An interface klass typed Phi with concrete inputs that are some real klass that implements that interface is processed by PhiNode::Value return tops for the Phi because the type system thinks they are unrelated. This kills off some paths which results in a malformed graph and we die in build_loop_late. This case is analagous to existing code that deals with this for instances and the logic just needs to be replicated for TypeKlassPtr. Tested by customer and by replaying original crash from core file. |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/cfgnode.cpp
17 lines changed: 17 ins; 0 del; 0 mod; 2056 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/type.cpp
10 lines changed: 10 ins; 0 del; 0 mod; 4024 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/type.hpp
2 lines changed: 2 ins; 0 del; 0 mod; 1242 unchg
This code review page was prepared using /net/smite.sfbay/never/bin/hgwebrev (vers 23.12-hg-never).