Code Review for 6744783

Prepared by: Thomas Rodriguez (never) on Wed Sep 24 12:14:45 PDT 2008
Workspace:/export/ws/flags
Compare against: /export/ws/baseline
Summary of changes: 9 lines changed: 3 ins; 0 del; 6 mod; 4020 unchg
Patch of changes: 6744783.patch
Author comments:
6744783: HotSpot segfaults if given -XX options with an empty string argument
Reviewed-by:
Contributed-by: volker.simonis@gmail.com

ccstr arguments should have a default empty value of NULL instead of
the empty string but the code that updates values wasn't being
consistent about this which could cause crashes. Tested with -XX
options using string arguments and -Xprintflags.

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.cpp

5 lines changed: 3 ins; 0 del; 2 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 3273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvmtiTrace.cpp

1 line changed: 0 ins; 0 del; 1 mod; 296 unchg

This code review page was prepared using /net/smite.sfbay/never/bin/hgwebrev (vers 23.12-hg-never).