| Prepared by: | Thomas Rodriguez (never) on Tue Sep 2 10:17:54 PDT 2008 |
|---|---|
| Workspace: | /export/ws/baseline |
| Compare against: | ssh://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
| Summary of changes: | 1 line changed: 0 ins; 0 del; 1 mod; 2710 unchg |
| Patch of changes: | 6738933.patch |
| Author comments: |
6738933: assert with base pointers must match with compressed oops enabled Reviewed-by: Loop opts attempts to clone loop invariant uses of loop varying values into the loop exits but because the clones don't actually differ from the original node GVN will simply recommon them. To deal with this it removes the clones from the worklist. There's a special case in there for loads because this causes assertion failures concerning the base of AddPs. This special case needs to be extended to included DecodeN since they also form the base of oop loads. If the cloning weren't so blind it could make sure that the cloned AddPs kept the same base but for now extending the special case is good enough. Tested with dacapo. |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/opto/loopopts.cpp
1 line changed: 0 ins; 0 del; 1 mod; 2710 unchg
This code review page was prepared using /net/smite.sfbay/never/bin/hgwebrev (vers 23.12-hg-never).