| Prepared by: | John Rose (jrose) on Mon Dec 8 17:22:59 PST 2008 |
|---|---|
| Workspace: | /scratch/jrose/ws/hs-6771309 |
| Compare against: | http://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot |
| Compare against version: | 460 |
| Summary of changes: | 267 lines changed: 213 ins; 12 del; 42 mod; 11666 unchg |
| Patch of changes: | hs-6771309.patch |
| Author comments: |
For putback to http://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: ?? When debugging the back end of the server compiler, we occasionally need to single-step into code that has been written in the AD file. This takes into generated files like ad_sparc.cpp, but we really want to examine and edit the original code in sparc.ad. Also includes minor enhancements to #define in adlc (works in more places, with more levels of indirection). Fix verified (y/n): y Verification testing: jprt with ADLCFLAGS += -g (temporarily). Also verified by building with ADLCFLAGS += -g and single-stepping back and forth between expressions in ad_sparc.cpp and sparc.ad. |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
make/linux/adlc_updater
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn10 lines changed: 8 ins; 0 del; 2 mod; 9 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
make/linux/makefiles/adlc.make
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn27 lines changed: 21 ins; 2 del; 4 mod; 195 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
make/solaris/adlc_updater
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn10 lines changed: 8 ins; 0 del; 2 mod; 9 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
make/solaris/makefiles/adlc.make
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn27 lines changed: 21 ins; 2 del; 4 mod; 211 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/adlc/adlparse.cpp
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn167 lines changed: 140 ins; 5 del; 22 mod; 4704 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/adlc/adlparse.hpp
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn8 lines changed: 7 ins; 0 del; 1 mod; 271 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/adlc/archDesc.cpp
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn1 line changed: 0 ins; 0 del; 1 mod; 1133 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/adlc/dfa.cpp
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn12 lines changed: 7 ins; 0 del; 5 mod; 1016 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/adlc/filebuff.hpp
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn1 line changed: 1 ins; 0 del; 0 mod; 101 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/adlc/formssel.cpp
rev 461 : Fixed 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn4 lines changed: 0 ins; 3 del; 1 mod; 4017 unchg
This code review page was prepared using /home/jrose/bin/hgwebrev (vers 23.12-hg-never).