Code Review for hs-6667042

Prepared by: John Rose (jrose) on Wed Feb 27 02:10:26 PST 2008
Workspace:/scratch/jrose/ws/hs-6667042
Compare against: http://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
Compare against version:16
Summary of changes: 2219 lines changed: 1594 ins; 542 del; 83 mod; 17763 unchg
Patch of changes: hs-6667042.patch
Author comments:
For putback to http://hg.openjdk.java.net/jdk7/hotspot-comp-gate/hotspot
6667042: PrintAssembly option does not work without special plugin
Summary: remove old private plugin interface, simplify, rework old plugin to use unchanged Gnu sources
Reviewed-by: kvn, rasbold 
Comments for reviewers:
 - This has been tested on SPARC and Intel, 32- and 64-bit versions.
 - The plugin is a separate project, a file of shim code between GNU binutils and HotSpot.
 - A sample implementation of the plugin is included in the tools directory.
 - A modest amount of printing code (for nmethod code comments) was moved from debug to product.
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .hgignore 

rev 17 : [mq]: 6667042.patch
1 line changed: 1 ins; 0 del; 0 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/linux/makefiles/vm.make 

rev 17 : [mq]: 6667042.patch
2 lines changed: 2 ins; 0 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/linux/platform_amd64 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/linux/platform_i486 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/linux/platform_sparc 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/makefiles/vm.make 

rev 17 : [mq]: 6667042.patch
2 lines changed: 2 ins; 0 del; 0 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_amd64 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_amd64.gcc 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_i486 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_i486.gcc 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_sparc 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_sparc.gcc 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_sparcv9 

rev 17 : [mq]: 6667042.patch
3 lines changed: 0 ins; 2 del; 1 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/solaris/platform_sparcv9.gcc 

rev 17 : [mq]: 6667042.patch
3 lines changed: 0 ins; 2 del; 1 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/windows/makefiles/vm.make 

rev 17 : [mq]: 6667042.patch
1 line changed: 1 ins; 0 del; 0 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/windows/platform_amd64 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 0 del; 2 mod; 13 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build/windows/platform_i486 

rev 17 : [mq]: 6667042.patch
4 lines changed: 1 ins; 2 del; 1 mod; 13 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/disassembler_sparc.hpp 

rev 17 : [mq]: 6667042.patch
28 lines changed: 1 ins; 20 del; 7 mod; 24 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/disassembler_x86.hpp 

rev 17 : [mq]: 6667042.patch
22 lines changed: 1 ins; 15 del; 6 mod; 24 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/asm/codeBuffer.cpp 

rev 17 : [mq]: 6667042.patch
1 line changed: 1 ins; 0 del; 0 mod; 1023 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.cpp 

rev 17 : [mq]: 6667042.patch
43 lines changed: 16 ins; 15 del; 12 mod; 2189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/nmethod.hpp 

rev 17 : [mq]: 6667042.patch
4 lines changed: 0 ins; 0 del; 4 mod; 574 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/vmreg.cpp 

rev 17 : [mq]: 6667042.patch
2 lines changed: 0 ins; 2 del; 0 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/vmreg.hpp 

rev 17 : [mq]: 6667042.patch
5 lines changed: 0 ins; 0 del; 5 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/oopMap.cpp 

rev 17 : [mq]: 6667042.patch
11 lines changed: 7 ins; 0 del; 4 mod; 658 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/oopMap.hpp 

rev 17 : [mq]: 6667042.patch
3 lines changed: 0 ins; 0 del; 3 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/includeDB_compiler1 

rev 17 : [mq]: 6667042.patch
1 line changed: 0 ins; 0 del; 1 mod; 434 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/includeDB_core 

rev 17 : [mq]: 6667042.patch
21 lines changed: 0 ins; 0 del; 21 mod; 4567 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.cpp 

rev 17 : [mq]: 6667042.patch
9 lines changed: 8 ins; 0 del; 1 mod; 2383 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp 

rev 17 : [mq]: 6667042.patch
11 lines changed: 3 ins; 0 del; 8 mod; 3200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/ostream.cpp 

rev 17 : [mq]: 6667042.patch
31 lines changed: 26 ins; 0 del; 5 mod; 845 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/ostream.hpp 

rev 17 : [mq]: 6667042.patch
2 lines changed: 1 ins; 0 del; 1 mod; 240 unchg

------ ------ ------ ------ --- New Patch Raw src/share/tools/hsdis/Makefile 

rev 17 : [mq]: 6667042.patch
135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/tools/hsdis/README 

rev 17 : [mq]: 6667042.patch
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/tools/hsdis/hsdis-demo.c 

rev 17 : [mq]: 6667042.patch
223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/tools/hsdis/hsdis.c 

rev 17 : [mq]: 6667042.patch
499 lines changed: 499 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/tools/hsdis/hsdis.h 

rev 17 : [mq]: 6667042.patch
67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/compiler/disassembler.cpp 

rev 17 : [mq]: 6667042.patch
445 lines changed: 445 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/vm/compiler/disassembler.hpp 

rev 17 : [mq]: 6667042.patch
59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/cpu/sparc/vm/disassembler_sparc.cpp

230 lines changed: 0 ins; 230 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/cpu/x86/vm/disassembler_x86.cpp

201 lines changed: 0 ins; 201 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/share/vm/compiler/disassemblerEnv.hpp

35 lines changed: 0 ins; 35 del; 0 mod; 0 unchg

This code review page was prepared using /home/jrose/bin/webrev (vers 23.4-hg).